Skip to content

Updating the Microsoft License [Rebase & FF]#22

Merged
makubacki merged 2 commits into
microsoft:mainfrom
Flickdm:feature/license
Nov 7, 2023
Merged

Updating the Microsoft License [Rebase & FF]#22
makubacki merged 2 commits into
microsoft:mainfrom
Flickdm:feature/license

Conversation

@Flickdm
Copy link
Copy Markdown
Member

@Flickdm Flickdm commented Nov 7, 2023

This updates the license to a limited liability license as per a discussion with corporate lawyers

@Flickdm Flickdm self-assigned this Nov 7, 2023
makubacki
makubacki reviewed Nov 7, 2023
View reviewed changes
Comment thread License.txt
@makubacki
Copy link
Copy Markdown
Member

makubacki commented Nov 7, 2023

Can you add the Secure Boot Objects license as a License.txt file in the release archive file?

@Javagedes
Copy link
Copy Markdown
Contributor

Javagedes commented Nov 7, 2023 •
edited
Loading

Can you add the Secure Boot Objects license as a License.txt file in the release archive file?

@Flickdm I can knock this out for you tomorrow morning if you like, otherwise, the below is a decent starting place for you:

I would add a cfg to the keystore.toml for license=<path>, then the update would be around scripts/secure_boot_default_keys.py L:326. to copy the license to each directory.

@makubacki makubacki changed the title Updating the Microsoft License Updating the Microsoft License [Rebase & FF] Nov 7, 2023
@makubacki
Copy link
Copy Markdown
Member

makubacki commented Nov 7, 2023

Can you add the Secure Boot Objects license as a License.txt file in the release archive file?

@Flickdm I can knock this out for you tomorrow morning if you like, otherwise, the below is a decent starting place for you:

I would add a cfg to the keystore.toml for license=, then the update would be around scripts/secure_boot_default_keys.py L:326. to copy the license to each directory.

I went ahead and added it in a separate commit, so I marked the PR for Rebase & FF.

Attached is an example of the generated md file.
README.md

@makubacki makubacki enabled auto-merge (rebase) November 7, 2023 02:48
@makubacki
Copy link
Copy Markdown
Member

makubacki commented Nov 7, 2023

Waiting for @Flickdm to confirm something with the lawyer, then I'll give my approval to merge the PR.

@Flickdm Flickdm requested a review from makubacki November 7, 2023 18:35
Flickdm and others added 2 commits November 7, 2023 14:17
@Flickdm @makubacki
Readme.md: Add Secure Boot Object license
a954079 
This license accompanies the data from the repo.

Also remove url from DefaultPk.files since it not needed.
@makubacki
Add Secure Boot Objects license to generated readme files
91491b6 
Updates secure_boot_default_keys.py to include the data license in
the release archives so it is carried with distribution.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki merged commit 58362cb into microsoft:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@makubacki makubacki makubacki approved these changes

@Javagedes Javagedes Javagedes approved these changes

Assignees

@Flickdm Flickdm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Flickdm @makubacki @Javagedes